lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 01 Mar 2009 00:12:28 -0800 (PST) From: David Miller <davem@...emloft.net> To: herbert@...dor.apana.org.au Cc: jarkao2@...il.com, ash@...sky.net, netdev@...r.kernel.org Subject: Re: Kernel problem From: Herbert Xu <herbert@...dor.apana.org.au> Date: Sun, 1 Mar 2009 15:38:01 +0800 > netpoll: Add drop checks to all entry points > > The netpoll entry checks are required to ensure that we don't > receive normal packets when invoked via netpoll. Unfortunately > it only ever worked for the netif_receive_skb/netif_rx entry > points. The VLAN (and subsequently GRO) entry point didn't > have the check and therefore can trigger all sorts of weird > problems. > > This patch adds the netpoll check to all entry points. > > I'm still uneasy with receiving at all under netpoll (which > apparently is only used by the out-of-tree kdump code). The > reason is it is perfectly legal to receive all data including > headers into highmem if netpoll is off, but if you try to do > that with netpoll on and someone gets a printk in an IRQ handler > you're going to get a nice BUG_ON. > > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> I don't blame you for being skitting about skb_bond_should_drop() :-) Applied, thanks Herbert! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists