netdev - Re: [PATCH]: ixgbe: Fix some compiler warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.WNT.4.64.0903012239150.29160@ppwaskie-MOBL2.amr.corp.intel.com>
Date:	Sun, 1 Mar 2009 22:40:12 -0800 (Pacific Standard Time)
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	David Miller <davem@...emloft.net>
cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [PATCH]: ixgbe: Fix some compiler warnings.

On Sun, 1 Mar 2009, David Miller wrote:

> @@ -661,7 +661,7 @@ static s32 ixgbe_poll_eeprom_eerd_done(struct ixgbe_hw *hw)
>  static s32 ixgbe_acquire_eeprom(struct ixgbe_hw *hw)
>  {
>         s32 status = 0;
> -       u32 eec;
> +       u32 eec = 0;
>         u32 i;
> 
>         if (ixgbe_acquire_swfw_sync(hw, IXGBE_GSSR_EEP_SM) != 0)
> diff --git a/drivers/net/ixgbe/ixgbe_dcb_82599.c b/drivers/net/ixgbe/ixgbe_dcb_82599.c
> index 1467d56..adcbac4 100644
> --- a/drivers/net/ixgbe/ixgbe_dcb_82599.c
> +++ b/drivers/net/ixgbe/ixgbe_dcb_82599.c
> @@ -457,8 +457,6 @@ s32 ixgbe_dcb_config_82599(struct ixgbe_hw *hw)
>  s32 ixgbe_dcb_hw_config_82599(struct ixgbe_hw *hw,
>                                struct ixgbe_dcb_config *dcb_config)
>  {
> -       u32  pap = 0;
> -

Thanks Dave.  We removed the code that used pap since it was used only for 
silicon validation, but we forgot to pull the variable.

Thanks for cleaning these up!

Cheers,
-PJ Waskiewicz
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html