netdev - Re: [PATCH v2] typhoon: Use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1235955774.3251.6.camel@bunthorne.i.decadent.org.uk>
Date:	Mon, 02 Mar 2009 01:02:54 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Dillow <dave@...dillows.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] typhoon: Use request_firmware()

On Sun, 2009-03-01 at 15:38 -0500, David Dillow wrote:
> On Thu, 2009-02-26 at 13:49 +0000, Ben Hutchings wrote:
> > Based on a patch by Jaswinder Singh <jaswinder@...radead.org>.
> > 
> > Compile-tested only.
> > 
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> 
> I suppose it's my fault for not getting around to this sooner, but I've
> been waiting for the fallout to settle with tg3 and follow the leader.
> 
> Anyways, is it too much to ask for you to CC the maintainer? Hell, you
> added a line right above my email address, so it wouldn't have been hard
> for you to find...

Sorry about that - I looked for a maintainer but there was no listing
for "typhoon" in MAINTAINERS nor any recent change to the driver that
was not part of a general API change.  Email addresses in source files
tend to be outdated, so I didn't look for them.  I see now that you have
an entry under "3CR990" in MAINTAINERS, but that isn't the driver name.
Please could you change that so that it's easier for people to find you?

> I suppose I better test this sooner rather than later, because I think
> you've broken it. The firmware gets vmalloc'd, which means it is not
> necessarily physically contiguous, and I don't think pci_map_single() is
> going to like that since the firmware is always larger than a page. But
> I may be wrong on this.

You could well be right.

Ben.

-- 
Ben Hutchings
In a hierarchy, every employee tends to rise to his level of incompetence.

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)