[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1235963807.27973.1.camel@localhost.localdomain>
Date: Sun, 01 Mar 2009 22:16:47 -0500
From: David Dillow <dave@...dillows.org>
To: David Miller <davem@...emloft.net>
Cc: ben@...adent.org.uk, netdev@...r.kernel.org
Subject: Re: [PATCH v2] typhoon: Use request_firmware()
On Sun, 2009-03-01 at 17:44 -0800, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Mon, 02 Mar 2009 01:02:54 +0000
>
> > On Sun, 2009-03-01 at 15:38 -0500, David Dillow wrote:
> > > I suppose I better test this sooner rather than later, because I think
> > > you've broken it. The firmware gets vmalloc'd, which means it is not
> > > necessarily physically contiguous, and I don't think pci_map_single() is
> > > going to like that since the firmware is always larger than a page. But
> > > I may be wrong on this.
> >
> > You could well be right.
>
> He is definitely right, this cannot work.
Do you want to revert, or do you a patch to fix it? Revert will be
quicker as I have to dig out hardware to test...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists