netdev - Re: [PATCH 1/2] dccp: Minimise header option overhead in setting the MPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090302.030803.184649276.davem@davemloft.net>
Date:	Mon, 02 Mar 2009 03:08:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	gerrit@....abdn.ac.uk
Cc:	dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] dccp: Minimise header option overhead in setting
 the MPS

From: Gerrit Renker <gerrit@....abdn.ac.uk>
Date: Sat, 28 Feb 2009 09:38:28 +0100

> This patch resolves a long-standing FIXME to dynamically update the Maximum
> Packet Size depending on actual options usage.
> 
> It uses the flags set by the feature-negotiation infrastructure to compute
> the required header option size.
> 
> Most options are fixed-size, a notable exception are Ack Vectors (required
> currently only by CCID-2). These can have any length between 3 and 1020
> bytes. As a result of testing, 16 bytes (2 bytes for type/length plus 14 Ack
> Vector cells) have been found to be sufficient for loss-free situations.
> 
> There are currently no CCID-specific header options which may appear on data
> packets, thus it is not necessary to define a corresponding CCID field as
> suggested in the old comment.
> 
> Further changes:
> ----------------
>  Adjusted the type of 'cur_mps' to match the unsigned return type of the
>  function.
> 
> Signed-off-by: Gerrit Renker <gerrit@....abdn.ac.uk>
> Acked-by: Ian McDonald <ian.mcdonald@...di.co.nz>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html