netdev - Re: PATCH tcp_init_wl / tcp_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090302.031401.177327405.davem@davemloft.net>
Date:	Mon, 02 Mar 2009 03:14:01 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ithilgore.ryu.l@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: PATCH tcp_init_wl / tcp_update_wl argument cleanup

From: "ithilgore.ryu.L@...il.com" <ithilgore.ryu.l@...il.com>
Date: Sun, 01 Mar 2009 12:37:47 +0200

> The above functions from include/net/tcp.h have been defined with an
> argument that they never use. The argument is 'u32 ack' which is never
> used inside the function body, and thus it can be removed. The rest of
> the patch involves the necessary changes to the function callers of the
> above two functions.

Please read linux/Documentation/SubmittingPatches

In particular, your submission:

1) Lacked a proper "Signed-off-by" line and please do fix
   the proper name assosciated with your email address if
   you don't mind.

2) Did not root your patch properly.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html