netdev - Re: [PATCH] tcp: '< 0' test on unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090302043056.GA16090@gondor.apana.org.au>
Date:	Mon, 2 Mar 2009 12:30:56 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] tcp: '< 0' test on unsigned

Roel Kluin <roel.kluin@...il.com> wrote:
>
> diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c
> index 25524d4..0b9d63f 100644
> --- a/net/ipv4/tcp_probe.c
> +++ b/net/ipv4/tcp_probe.c
> @@ -167,7 +167,7 @@ static ssize_t tcpprobe_read(struct file *file, char __user *buf,
> {
>        int error = 0, cnt = 0;
> 
> -       if (!buf || len < 0)
> +       if (!buf || (ssize_t)len < 0)
>                return -EINVAL;
> 
>        while (cnt < len) {

Either cnt needs to be promoted, or you need to limit len to INT_MAX.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html