netdev - Re: [patch 1/1] netns : fix addrconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 03 Mar 2009 01:07:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dlezcano@...ibm.com
Cc:	benjamin.thery@...il.com, netdev@...r.kernel.org
Subject: Re: [patch 1/1] netns : fix addrconf_ifdown kernel panic

From: Daniel Lezcano <dlezcano@...ibm.com>
Date: Fri, 27 Feb 2009 19:26:59 +0100

> When a network namespace is destroyed the network interfaces are
> all unregistered, making addrconf_ifdown called by the netdevice
> notifier. 
> In the other hand, the addrconf exit method does a loop on the network
> devices and does addrconf_ifdown on each of them. But the ordering of 
> the netns subsystem is not right because it uses the register_pernet_device
> instead of register_pernet_subsys. If we handle the loopback as
> any network device, we can safely use register_pernet_subsys.
> 
> But if we use register_pernet_subsys, the addrconf exit method will do
> exactly what was already done with the unregistering of the network
> devices. So in definitive, this code is pointless.
> 
> I removed the netns addrconf exit method and moved the code to the
> addrconf cleanup function.
> 
> Signed-off-by: Daniel Lezcano <dlezcano@...ibm.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html