netdev - Re: [BUG] 2.6.29-rc* QinQ vlan trunking regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090304.234526.185561836.davem@davemloft.net>
Date:	Wed, 04 Mar 2009 23:45:26 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	bart@...ie.net, greearb@...delatech.com, shemminger@...tta.com,
	dada1@...mosbay.com, frank.blaschka@...ibm.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [BUG] 2.6.29-rc* QinQ vlan trunking regression

From: Patrick McHardy <kaber@...sh.net>
Date: Thu, 05 Mar 2009 08:31:31 +0100

> Patrick McHardy wrote:
> > David Miller wrote:
> >> From: Patrick McHardy <kaber@...sh.net>
> >> Date: Thu, 05 Mar 2009 08:12:50 +0100
> >>
> >>>> We probably need both fixes to cover everything.
> >>>>
> >>> Yes, just the second one still crashes. I'm about to retry using both.
> >>
> >> Here is the updated version just for the record:
> >>
> >> vlan: Fix vlan-in-vlan crashes.
> > This still crashes. I'll have another look at the code.
> 
> This one combined with your patch fixes the crash. The code was calling
> vlan_dev_neigh_setup recursively.
> 
> Signed-off-by: Patrick McHardy <kaber@...sh.net>
> 
> (or Tested-by: in case you want to roll it into your patch).

Great work, thanks Patrick!

I'll get this all integrated and push it out to Linus.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html