netdev - Re: [PATCH] tulip: Fix for MTU problems with 802.1q tagged frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49B11BA6.7060103@netservers.co.uk>
Date:	Fri, 06 Mar 2009 12:48:38 +0000
From:	Ben McKeegan <ben@...servers.co.uk>
To:	Ivan Vecera <ivecera@...hat.com>
CC:	netdev@...r.kernel.org, grundler@...isc-linux.org,
	kyle@...artin.ca, Tomasz Lemiech <szpajder@...szic.waw.pl>
Subject: Re: [PATCH] tulip: Fix for MTU problems with 802.1q tagged frames

Ivan Vecera wrote:
> The original patch was submitted last year but wasn't discussed or applied
> because of missing maintainer's CCs. I only fixed some formatting errors,
> but as I saw tulip is very badly formatted and needs further work.
> 
> Original description:
> This patch fixes MTU problem, which occurs when using 802.1q VLANs. We
> should allow receiving frames of up to 1518 bytes in length, instead of
> 1514.
> 
> Based on patch written by Ben McKeegan for 2.4.x kernels. It is archived
> at http://www.candelatech.com/~greear/vlan/howto.html#tulip
> I've adjusted a few things to make it apply on 2.6.x kernels.
> 
> Tested on D-Link DFE-570TX quad-fastethernet card.
> 
> Signed-off-by: Tomasz Lemiech <szpajder@...szic.waw.pl>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>

Looks good.  FWIW:

Signed-off-by: Ben McKeegan <ben@...servers.co.uk>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html