netdev - Re: [PATCH 1/2] gigaset: return -ENOSYS for unimplemented functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090307163522.1165494b@infradead.org>
Date:	Sat, 7 Mar 2009 16:35:22 -0800
From:	Arjan van de Ven <arjan@...radead.org>
To:	Tilman Schmidt <tilman@...p.cc>
Cc:	davem@...emloft.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Paul Bolle <pebolle@...cali.nl>,
	Hansjoerg Lipp <hjlipp@....de>
Subject: Re: [PATCH 1/2] gigaset: return -ENOSYS for unimplemented functions

On Sun, 08 Mar 2009 01:22:28 +0100
Tilman Schmidt <tilman@...p.cc> wrote:

> Am 07.03.2009 23:26 schrieb Arjan van de Ven:
> > On Sat,  7 Mar 2009 23:10:57 +0100 (CET)
> > Tilman Schmidt <tilman@...p.cc> wrote:
> > 
> >> From: Paul Bolle <pebolle@...cali.nl>
> >>
> >> A number of functions in the usb_gigaset module will return
> >> -EINVAL if CONFIG_GIGASET_UNDOCREQ is not set. Make these return
> >> -ENOSYS as it's more specific and it might make it easier to see
> >> (from userspace) why these functions actually fail.
> >>
> >> Impact: some error return codes changed
> > 
> > ENODEV is what would be more appropriate.
> 
> Not at all. ENODEV means "no such device", which would be quite wrong.
> The device does exist and is in all probability working perfectly
> fine. It just doesn't implement that particular ioctl.

then -ENOTTY is the right answer
-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html