netdev - Re: MACVLANs really best solution? How about a bridge with multiple bridge virtual interfaces?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49B5478C.4020001@trash.net>
Date:	Mon, 09 Mar 2009 17:45:00 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Mark Smith 
	<nanog@...5b20a518b8f6864949bd940457dc124746ddc.nosense.org>,
	greearb@...delatech.com, David Miller <davem@...emloft.net>,
	netdev@...r.kernel.org, shemminger@...ux-foundation.org
Subject: Re: MACVLANs really best solution? How about a bridge with multiple
 bridge virtual interfaces?

Eric W. Biederman wrote:
> Patrick McHardy <kaber@...sh.net> writes:
> 
>> Eric W. Biederman wrote:
>>> There are two tricky parts.
>>>
>>> One problem is that macvlans and the primary hardware device share the
>>> same transmit queue.  So when I have a broadcast packet on the primary
>>> devices queue I don't know if I have already sent it out to the
>>> macvlan devices or not.
>> So its about receiving packets on macvlan when transmitting on the
>> real device? That sounds like a really hard problem that would probably
>> indeed be better solved by a bridge.
> 
> Yes.  My concern is that if we hook the real device we will
> software broadcast packets twice.

It would also require an additional hook in the networking core,
right? Which doesn't seem appropriate for a corner case like this.

> Now that I think about it we could call ndo_start_xmit directly
> from the macvlan code, and bypass whatever hook we use to
> intercept packets going out the normal device it should not
> be too difficult.

We don't intercept packets on TX, they have to be explicitly delivered
to macvlan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html