netdev - Re: [PATCH 12/13] forcedeth: fix irq clearing and napi spin lock changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090310.053256.51838844.davem@davemloft.net>
Date:	Tue, 10 Mar 2009 05:32:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	aabdulla@...dia.com
Cc:	jgarzik@...ox.com, manfred@...orfullife.com, akpm@...l.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 12/13] forcedeth: fix irq clearing and napi spin lock
 changes

From: Ayaz Abdulla <aabdulla@...dia.com>
Date: Thu, 05 Mar 2009 13:02:34 -0500

> This patch clears the irqstatus register with the exact same events it has read from it. Since the read-write operation is not atomic, a new irqstatus bit could have been set in between these operations and would then be cleared accidentally.
> 
> Secondly, we now don't need any spin lock protection when scheduling/completing napi poll as the isr will not execute anymore (as we turn off all interrupts now).
> 
> Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html