netdev - Re: Passive OS fingerprint xtables match (iptables)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.0903101708150.19523@fbirervta.pbzchgretzou.qr>
Date:	Tue, 10 Mar 2009 17:12:09 +0100 (CET)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Evgeniy Polyakov <zbr@...emap.net>
cc:	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Netfilter Development Mailinglist 
	<netfilter-devel@...r.kernel.org>
Subject: Re: Passive OS fingerprint xtables match (iptables)


>static void osf_init(struct xt_entry_match *m)
>{
>}
>
You can remove this function, as it does no initialization.
Implicit NULL in struct xtables_match is handled.

>		case '2': /* --ttl */
>			if (*flags & IPT_OSF_TTL)
>				exit_error(PARAMETER_PROBLEM, "Can't specify multiple ttl parameter");
>			*flags |= IPT_OSF_TTL;
>			info->flags |= IPT_OSF_TTL;
>			info->ttl = atoi(argv[optind-1]);

This would allow specifying --ttl 12345.

Use of xtables_strtoui (v1.4.3-rc1+git) for bounds checking,
and use of optarg seem beneficial:

	unsigned int num;

	if (!xtables_strtoui(optarg, NULL, &num, 0, UINT8_MAX))
		exit_error(PARAMETER_PROBLEM, "*shrug*");
	info->ttl = num;

>		case '3': /* --log */
>			if (*flags & IPT_OSF_LOG)
>				exit_error(PARAMETER_PROBLEM, "Can't specify multiple log parameter");
>			*flags |= IPT_OSF_LOG;
>			info->loglevel = atoi(argv[optind-1]);

similarly.

>			info->flags |= IPT_OSF_LOG;
>			break;
>[...]
>	return 1;
>}
>
>static void osf_final_check(unsigned int flags)
>{
>	if (!flags)
>		exit_error(PARAMETER_PROBLEM, "OS fingerprint match: You must specify `--genre'");
>}
>
>static struct xtables_match osf_match = {
>	.name		= "osf",
>	.version	= XTABLES_VERSION,
>	.size		= XT_ALIGN(sizeof(struct ipt_osf_info)),
>	.userspacesize	= XT_ALIGN(sizeof(struct ipt_osf_info)),
>	.help		= osf_help,
>	.init		= osf_init,
>	.parse		= osf_parse,
>	.print		= osf_print,
>	.final_check	= osf_final_check,
>	.save		= osf_save,
>	.extra_opts	= osf_opts
>};

Needs .family = NFPROTO_IPV4.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html