netdev - Re: [PATCH] dnet: Dave DNET ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090310211841.388619ca@nehalam>
Date:	Tue, 10 Mar 2009 21:18:41 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Ilya Yanok <yanok@...raft.com>
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk, netdev@...r.kernel.org,
	s.hauer@...gutronix.de, wd@...x.de, dzu@...x.de,
	Ilya Yanok <yanok@...raft.com>
Subject: Re: [PATCH] dnet: Dave DNET ethernet controller driver

On Wed, 11 Mar 2009 05:29:09 +0300
Ilya Yanok <yanok@...raft.com> wrote:

> +static char ethaddr[18];
> +
> +module_param_string(ethaddr, ethaddr, sizeof(ethaddr), 0);
> +
> +static void get_mac_addr(struct net_device *nd, unsigned char *pmac)
> +{
> +	int i;
> +	char *p = ethaddr;
> +
> +	ethaddr[17] = 0;
> +	for (i = 0; i < ETH_ALEN; i++, p++) {
> +		pmac[i] = simple_strtoul(p, &p, 16);
> +		if (*p != ':')
> +			break;
> +	}
> +	if (i != ETH_ALEN - 1) {
> +		pr_err("Wrong MAC address format!\n");
> +		memset(pmac, 0, ETH_ALEN);
> +	}
> +}
> +

Do you still need this? Only works with one board, configuration via
module parameters is discouraged.  Same effect can be done by setting
mac address with regular tools.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html