netdev - Re: [PATCH] dnet: Dave DNET ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090311090938.E7BF7832E8B8@gemini.denx.de>
Date:	Wed, 11 Mar 2009 10:09:38 +0100
From:	Wolfgang Denk <wd@...x.de>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, yanok@...raft.com,
	linux-arm-kernel@...ts.arm.linux.org.uk, netdev@...r.kernel.org,
	dzu@...x.de
Subject: Re: [PATCH] dnet: Dave DNET ethernet controller driver

Dear David,

on Wed, Mar 11, 2009 at 01:49:57AM -0700, David Miller wrote:
> From: Sascha Hauer <s.hauer@...gutronix.de>
> Date: Wed, 11 Mar 2009 09:44:30 +0100
> 
> > On Tue, Mar 10, 2009 at 09:18:41PM -0700, Stephen Hemminger wrote:
> > > Do you still need this? Only works with one board, configuration via
> > > module parameters is discouraged.  Same effect can be done by setting
> > > mac address with regular tools.
> > 
> > Except for root over nfs. Ok, the answer to this is usually 'use
> > initrd', but this is still a pita on embedded systems.
> 
> Please remove this code.  If we let you do it, we have to let everyone
> else do it too, and that's something we don't want to do.
> 
> There are other ways you can handle this, for example have your board
> firmware properly program the MAC address into the card at power-on,
> and then have the driver here look in the MAC address registers to see
> if a valid ethernet address has been left there.

How do you then handle situations where this is impossible? Say, when
the firmware cannot write to those registers for example because  the
ethernet  controller is not even powered on (to reduce power consump-
tion), but will get powered on only in Linux  when  the  driver  gets
loaded (i. e. on demand only, not always)?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@...x.de
"If God had wanted us to use the metric system, Jesus would have  had
10 apostles."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html