netdev - Re: [Patch 4/5] Network Drop Monitor: Adding drop monitor implementation & Netlink protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090311.091754.99441674.davem@davemloft.net>
Date:	Wed, 11 Mar 2009 09:17:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, pekkas@...core.fi,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net
Subject: Re: [Patch 4/5] Network Drop Monitor: Adding drop monitor
 implementation & Netlink protocol

From: Neil Horman <nhorman@...driver.com>
Date: Thu, 5 Mar 2009 14:27:06 -0500

> +struct net_dm_drop_point {
> +	uint8_t pc[8];
> +	uint32_t count;
> +};

Please use "__u8", "__u32", etc. and you'll get those as a result
of your linux/netlink.h include at the top of this file.

> +#define RCV_SKB_FAIL(err) do { netlink_ack(skb, nlh, (err)); return; } while (0)

Please don't embed return statements in macors, this makes the
code nearly impossible to audit.

I don't even see this macro being used in the code :-)

Otherwise this looks fine.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html