netdev - Re: [PATCH] igb: allow tx of pre-formatted vlan tagged packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090312212502.GB14957@ajones-laptop.nbttech.com>
Date:	Thu, 12 Mar 2009 14:25:02 -0700
From:	Arthur Jones <ajones@...erbed.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] igb: allow tx of pre-formatted vlan tagged packets

Hi Stephen, ...

On Thu, Mar 12, 2009 at 01:51:19PM -0700, Stephen Hemminger wrote:
> On Thu, 12 Mar 2009 13:27:24 -0700
> Arthur Jones <ajones@...erbed.com> wrote:
> 
> > When the 82575 is fed 802.1q packets, it chokes with
> > an error of the form:
> > 
> > igb 0000:08:00.1: partial checksum but proto=81
> > 
> > As the logic there was not smart enough to look into
> > the vlan header to pick out the encapsulated protocol.
> > 
> > There are times when we'd like to send these packets
> > out without having to configure a vlan on the interface.
> > Here we check for the vlan tag and allow the packet to
> > go out with the correct hardware checksum.
> > 
> > Thanks to Kand Ly <kand@...erbed.com> for discovering the
> > issue and the coming up with a solution.  This patch is
> > based upon his work.
> > 
> > Signed-off-by: Arthur Jones <ajones@...erbed.com>
> > ---
> >  drivers/net/igb/igb_main.c |   12 +++++++++++-
> >  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> That code in current igb driver (net-next-2.6) tree no longer has
> the whole switch you are changing.

The patch from linux-2.6 applies to net-next-2.6
with just a minor context fixup.  I think the issue
still exists in net-next-2.6, I'm compiling and testing
now...

Arthur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html