netdev - Re: [PATCH 2/2] r8169: revert "r8169: read MAC address from EEPROM on init (2nd attempt)"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18877.41709.567947.25614@pilspetsen.it.uu.se>
Date:	Mon, 16 Mar 2009 01:53:01 +0100
From:	Mikael Pettersson <mikpe@...uu.se>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Dave Jones <davej@...hat.com>,
	Mikael Pettersson <mikpe@...uu.se>,
	Tim Durack <tdurack@...il.com>, ivecera@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] r8169: revert "r8169: read MAC address from EEPROM on
	init (2nd attempt)"

Francois Romieu writes:
 > It fails on the following systems:
 > - RTL8169sc/8110sc (XID 18000000)
 >   reported by Tim Durack <tdurack@...il.com> (x86)
 > - RTL8169sb/8110sb (XID 10000000)
 >   reported by Mikael Pettersson <mikpe@...uu.se> (ARM)
 > 
 > The patch appeared to work on x86 for the following systems:
 > RTL8169sb/8110sb 10000000 PCI   (EXT)
 > RTL8110s         04000000 PCI   (EXT)
 > RTL8102e         24a00000 PCI-E (LOM)
 > RTL8168c/8111c   3c2000c0 PCI-E (LOM)
 > RTL8168b/8111b   38000000 PCI-E (LOM)
 > RTL8168b/8111b   38000000 PCI-E (EXT)
 > 
 > The patch exposes two problems:
 > 1) while not completely wrong, mac addresses are not read correctly
 >    from the EEPROM
 > 2) the MAC address registers are not correctly set
 > 
 > Signed-off-by: Francois Romieu <romieu@...zoreil.com>

Thanks. With these two patches applied 2.6.29-rc8 now works fine
with the r8169 in my NAS box.

Tested-by: Mikael Pettersson <mikpe@...uu.se>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html