[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <49BE6257.5070008@redhat.com>
Date: Mon, 16 Mar 2009 15:29:43 +0100
From: Ivan Vecera <ivecera@...hat.com>
To: Francois Romieu <romieu@...zoreil.com>
CC: "David S. Miller" <davem@...emloft.net>,
Dave Jones <davej@...hat.com>,
Mikael Pettersson <mikpe@...uu.se>,
Tim Durack <tdurack@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] r8169: revert "r8169: read MAC address from EEPROM
on init (2nd attempt)"
Francois Romieu wrote:
> It fails on the following systems:
> - RTL8169sc/8110sc (XID 18000000)
> reported by Tim Durack <tdurack@...il.com> (x86)
> - RTL8169sb/8110sb (XID 10000000)
> reported by Mikael Pettersson <mikpe@...uu.se> (ARM)
>
> The patch appeared to work on x86 for the following systems:
> RTL8169sb/8110sb 10000000 PCI (EXT)
> RTL8110s 04000000 PCI (EXT)
> RTL8102e 24a00000 PCI-E (LOM)
> RTL8168c/8111c 3c2000c0 PCI-E (LOM)
> RTL8168b/8111b 38000000 PCI-E (LOM)
> RTL8168b/8111b 38000000 PCI-E (EXT)
>
> The patch exposes two problems:
> 1) while not completely wrong, mac addresses are not read correctly
> from the EEPROM
> 2) the MAC address registers are not correctly set
>
Maybe it should be better to introduce a module param to disable/enable
this feature instead of the removal.
Ivan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists