netdev - Re: [PATCH v2] pkt_sched: Change misleading code in class delete.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090315.200032.194674635.davem@davemloft.net>
Date:	Sun, 15 Mar 2009 20:00:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	m0sia@...ia.ru, kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2] pkt_sched: Change misleading code in class delete.

From: Jarek Poplawski <jarkao2@...il.com>
Date: Sun, 15 Mar 2009 13:35:11 +0100

> While looking for a possible reason of bugzilla report on HTB oops:
> http://bugzilla.kernel.org/show_bug.cgi?id=12858
> I found the code in htb_delete calling htb_destroy_class on zero
> refcount is very misleading: it can suggest this is a common path, and
> destroy is called under sch_tree_lock. Actually, this can never happen
> like this because before deletion cops->get() is done, and after
> delete a class is still used by tclass_notify. The class destroy is
> always called from cops->put(), so without sch_tree_lock.
> 
> This doesn't mean much now (since 2.6.27) because all vulnerable calls
> were moved from htb_destroy_class to htb_delete, but there was a bug
> in older kernels. The same change is done for other classful scheds,
> which, it seems, didn't have similar locking problems here.
> 
> Reported-by: m0sia <m0sia@...ia.ru>
> Signed-off-by: Jarek Poplawski <jarkao2@...il.com>

Applied, thanks a lot Jarek.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html