netdev - Re: [patch 0/6] netfilter: ctnetlink allocation improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090317100350.GA3526@mail.eitzenberger.org>
Date:	Tue, 17 Mar 2009 11:03:51 +0100
From:	Holger Eitzenberger <holger@...zenberger.org>
To:	Pablo Neira Ayuso <pablo@...filter.org>
Cc:	Patrick McHardy <kaber@...sh.net>,
	David Miller <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch 0/6] netfilter: ctnetlink allocation improvement

On Tue, Mar 17, 2009 at 10:49:00AM +0100, Pablo Neira Ayuso wrote:

> > Though I haven't got any hard performance numbers yet I think this
> > might introduce a noticable performance gain.
> 
> I'm not sure about this. Instead, I noticed with oprofile that we spend
> more cycles to calculate the message size. I think it's more like a
> trade-off, reducing the message size to what we need reduces the chances
> to hit ENOBUFS.

Hi Pablo,

your patch is a bit different, as you do the message length
calculation on each packet.  Instead I do it once at compile time for
the proto independant part and then later for each protocol helper at
the time it is registered.  At unload time the helper is replaced by
the generic one (which implies =0 always).

Cheers,

 /holger

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html