netdev - Re: Kernel panic during stress with igb in the upstream kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090317.131105.111221133.davem@davemloft.net>
Date:	Tue, 17 Mar 2009 13:11:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	jarkao2@...il.com, emil.s.tantilov@...el.com,
	alexander.h.duyck@...el.com, jesse.brandeburg@...el.com,
	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org
Subject: Re: Kernel panic during stress with igb in the upstream kernel

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 17 Mar 2009 18:02:03 +0800

> On Tue, Mar 17, 2009 at 09:37:24AM +0000, Jarek Poplawski wrote:
> >
> > Probably I miss something, but you seem to assume here this skb will
> > be taken by netpoll later. But if it's not active (trapped) vlan
> > packet will be passed as "normal"?
> 
> Good point.  I'll see if this stuff can be simplified further,
> but for now, let's go for the obvious fix.
> 
> gro: Fix vlan/netpoll check again
> 
> Jarek Poplawski pointed out that my previous fix is broken for
> VLAN+netpoll as if netpoll is enabled we'd end up in the normal
> receive path instead of the VLAN receive path.
> 
> This patch fixes it by calling the VLAN receive hook.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks Herbert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html