netdev - Re: [Bugme-new] [Bug 12886] New: skge wake on lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903172223.14608.rjw@sisk.pl>
Date:	Tue, 17 Mar 2009 22:23:13 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Tomi Orava" <tomimo@...rcle.nullnet.fi>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	bugme-daemon@...zilla.kernel.org, netdev@...r.kernel.org,
	"Stephen Hemminger" <shemminger@...ux-foundation.org>
Subject: Re: [Bugme-new] [Bug 12886] New: skge wake on lan

On Tuesday 17 March 2009, Tomi Orava wrote:
> 
> Hi,
> 
> > Please tell me what exactly you do to set up WoL.
> 
> The only thing I do is I configure the WOL bios option
> to on ie. no OS based configuration settings are touched.

Hmm.

> The previously mentioned patch reverted the ethtool output is
> (ie. this is a working 2.6.28.7 system atm):

I wonder what it shows if that commit is not reverted (in fact it is necessary
on some other systems for things to work correctly).

Also, please check if the appended patch helps (of course, without reverting
the commit).

---
 drivers/net/skge.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux-2.6/drivers/net/skge.c
===================================================================
--- linux-2.6.orig/drivers/net/skge.c
+++ linux-2.6/drivers/net/skge.c
@@ -3856,8 +3856,9 @@ static struct net_device *skge_devinit(s
 	skge->speed = -1;
 	skge->advertising = skge_supported_modes(hw);
 
-	if (device_may_wakeup(&hw->pdev->dev))
-		skge->wol = wol_supported(hw) & WAKE_MAGIC;
+	skge->wol = wol_supported(hw) & WAKE_MAGIC;
+	if (skge->wol && device_can_wakeup(&hw->pdev->dev))
+		device_set_wakeup_enable(&hw->pdev->dev, true);
 
 	hw->dev[port] = dev;
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html