netdev - Re: [PATCH] fix sctp breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2009 08:28:44 -0400
From:	Vlad Yasevich <vladislav.yasevich@...com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] fix sctp breakage

Al Viro wrote:
> broken by commit 5e739d1752aca4e8f3e794d431503bfca3162df4; AFAICS should
> be -stable fodder as well...
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
> diff --git a/net/sctp/endpointola.c b/net/sctp/endpointola.c
> index 4c8d9f4..905fda5 100644
> --- a/net/sctp/endpointola.c
> +++ b/net/sctp/endpointola.c
> @@ -111,7 +111,8 @@ static struct sctp_endpoint *sctp_endpoint_init(struct sctp_endpoint *ep,
>  		if (sctp_addip_enable) {
>  			auth_chunks->chunks[0] = SCTP_CID_ASCONF;
>  			auth_chunks->chunks[1] = SCTP_CID_ASCONF_ACK;
> -			auth_chunks->param_hdr.length += htons(2);
> +			auth_chunks->param_hdr.length =
> +					htons(sizeof(sctp_paramhdr_t) + 2);
>  		}
>  	}
>  

ACK.  That wasn't a good way to write that increment.  I should have thought more
about it, but at the time it seemed like a good idea...

Thanks
-vlad

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html