netdev - Re: [PATCHv3] netns: oops in ip[6]_frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2009 23:09:27 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	jorge@...2.net, netdev@...r.kernel.org
Subject: Re: [PATCHv3] netns: oops in ip[6]_frag_reasm incrementing stats

On Thu, Mar 19, 2009 at 02:56:49PM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@...il.com>
> Date: Thu, 19 Mar 2009 22:54:28 +0100
> 
> > On Wed, Mar 18, 2009 at 11:26:51PM -0700, David Miller wrote:
> > > Netfilter on ipv6 handles reassembly differently and in a way
> > > that won't result in dev being NULL here.
> > > 
> > > I've applied Jorge's patch, thanks everyone.
> > 
> > My proposal is to revert the ipv6/reassembly part of this patch yet;
> > it doesn't fix anything, and the changelog is only misleading if it's
> > like you said.
> 
> I've already pushed the change out to net-2.6 so I'd really prefer not
> to do that.  Make your desires known more emphatically before a patch
> has been sitting around for days.

I guess you should re-read the thread: if not me, the author of this
patch was very emphatical...

> 
> At worst it's a consistency cleanup with an inaccurate commit message,
> reverting will only make the situation more confusing and ugly.

Sure, no big deal.

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html