netdev - Re: [PATCH 32/77] usbnet: convert rndis driver to use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903210222.06107.david-b@pacbell.net>
Date:	Sat, 21 Mar 2009 02:22:05 -0700
From:	David Brownell <david-b@...bell.net>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 32/77] usbnet: convert rndis driver to use dev_get_stats

On Friday 20 March 2009, Stephen Hemminger wrote:
> dev_get_stats() handles all issues with net_device_ops
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>


> ---
>  drivers/usb/gadget/rndis.c |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> --- a/drivers/usb/gadget/rndis.c	2009-03-20 12:18:22.054027493 -0700
> +++ b/drivers/usb/gadget/rndis.c	2009-03-20 12:18:28.620714647 -0700
> @@ -170,7 +170,7 @@ gen_ndis_query_resp (int configNr, u32 O
>  	int			i, count;
>  	rndis_query_cmplt_type	*resp;
>  	struct net_device	*net;
> -	struct net_device_stats	*stats;
> +	const struct net_device_stats	*stats;
>  
>  	if (!r) return -ENOMEM;
>  	resp = (rndis_query_cmplt_type *) r->buf;
> @@ -193,10 +193,7 @@ gen_ndis_query_resp (int configNr, u32 O
>  	resp->InformationBufferOffset = cpu_to_le32 (16);
>  
>  	net = rndis_per_dev_params[configNr].dev;
> -	if (net->get_stats)
> -		stats = net->get_stats(net);
> -	else
> -		stats = NULL;
> +	stats = dev_get_stats(net);
>  
>  	switch (OID) {
>  
> 
> -- 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html