netdev - Re: [PATCH 33/77] usbnet: convert rndis driver to net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Mar 2009 02:23:09 -0700
From:	David Brownell <david-b@...bell.net>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 33/77] usbnet: convert rndis driver to net_device_ops

On Friday 20 March 2009, Stephen Hemminger wrote:
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>


> --- a/drivers/net/usb/rndis_host.c	2009-03-20 12:18:22.041027638 -0700
> +++ b/drivers/net/usb/rndis_host.c	2009-03-20 12:27:20.541841282 -0700
> @@ -266,6 +266,16 @@ response_error:
>  	return -EDOM;
>  }
>  
> +/* same as usbnet_netdev_ops but MTU change not allowed */
> +static const struct net_device_ops rndis_netdev_ops = {
> +	.ndo_open		= usbnet_open,
> +	.ndo_stop		= usbnet_stop,
> +	.ndo_start_xmit		= usbnet_start_xmit,
> +	.ndo_tx_timeout		= usbnet_tx_timeout,
> +	.ndo_set_mac_address 	= eth_mac_addr,
> +	.ndo_validate_addr	= eth_validate_addr,
> +};
> +
>  int
>  generic_rndis_bind(struct usbnet *dev, struct usb_interface *intf, int flags)
>  {
> @@ -327,7 +337,8 @@ generic_rndis_bind(struct usbnet *dev, s
>  	dev->rx_urb_size &= ~(dev->maxpacket - 1);
>  	u.init->max_transfer_size = cpu_to_le32(dev->rx_urb_size);
>  
> -	net->change_mtu = NULL;
> +	net->netdev_ops = &rndis_netdev_ops;
> +
>  	retval = rndis_command(dev, u.header, CONTROL_BUFFER_SIZE);
>  	if (unlikely(retval < 0)) {
>  		/* it might not even be an RNDIS device!! */
> 
> -- 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html