netdev - Re: [PATCH 2/2] ixgbe: fix select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2390903201724r863d13cr1ad47ade2c3d0223@mail.gmail.com>
Date:	Fri, 20 Mar 2009 17:24:17 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Cc:	Stephen Hemminger <shemminger@...tta.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 2/2] ixgbe: fix select_queue management

On Fri, Mar 20, 2009 at 10:14 AM, Waskiewicz Jr, Peter P
<peter.p.waskiewicz.jr@...el.com> wrote:
> On Fri, 20 Mar 2009, Stephen Hemminger wrote:
>
>> On Fri, 20 Mar 2009 00:23:39 -0700 (Pacific Daylight Time)
>> "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com> wrote:
>>
>> > On Thu, 19 Mar 2009, Stephen Hemminger wrote:
>> >
>> > > Convert ixgbe to use net_device_ops properly.
>> > > Rather than changing the select_queue function pointer
>> > > just check the flag.
>> > >
>> > > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>> >
>> > Thanks Stephen.  I was looking at reassigning a DCB netdev_ops struct when
>> > DCB is enabled, and then having a default netdev_ops struct when it's not
>> > enabled.  I agree the check is cleaner the way you have it below, but it's
>> > another conditional check in the Tx hotpath, which we have too many of in
>> > the first place.
>>
>> Changing number of tx queues is actually the fastest, since then
>> indirection is not needed
>>
>> > On a related side note, why is the netdev_ops member of net_device
>> > declared const?
>>
>> The purpose of having an ops structure is two fold. First, the ops
>> can be in read-only section (if driver wants) to avoid cache issues.
>> More importantly only one instance is necessary when there are multiple
>> boards, or 1000's of vlans.
>
> Ah, gotcha.  Clears up my questions.
>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> --

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Dave - feel free to apply this patch when you take the first patch in
this series, I am not adding this to me tree.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html