netdev - Re: [PATCH 30/77] usbnet: convert msc7830 driver to net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200903210219.17593.david-b@pacbell.net>
Date:	Sat, 21 Mar 2009 02:19:17 -0700
From:	David Brownell <david-b@...bell.net>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 30/77] usbnet: convert msc7830 driver to net_device_ops

On Friday 20 March 2009, Stephen Hemminger wrote:
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

cc'd driver maintainer


> 
> --- a/drivers/net/usb/mcs7830.c	2009-03-20 12:11:35.680902515 -0700
> +++ b/drivers/net/usb/mcs7830.c	2009-03-20 12:16:27.334776706 -0700
> @@ -486,6 +486,18 @@ static int mcs7830_set_mac_address(struc
>  	return 0;
>  }
>  
> +static const struct net_device_ops mcs7830_netdev_ops = {
> +	.ndo_open		= usbnet_open,
> +	.ndo_stop		= usbnet_stop,
> +	.ndo_start_xmit		= usbnet_start_xmit,
> +	.ndo_tx_timeout		= usbnet_tx_timeout,
> +	.ndo_change_mtu		= usbnet_change_mtu,
> +	.ndo_validate_addr	= eth_validate_addr,
> +	.ndo_do_ioctl 		= mcs7830_ioctl,
> +	.ndo_set_multicast_list = mcs7830_set_multicast,
> +	.ndo_set_mac_address	 = mcs7830_set_mac_address,
> +};
> +
>  static int mcs7830_bind(struct usbnet *dev, struct usb_interface *udev)
>  {
>  	struct net_device *net = dev->net;
> @@ -495,11 +507,9 @@ static int mcs7830_bind(struct usbnet *d
>  	if (ret)
>  		goto out;
>  
> -	net->do_ioctl = mcs7830_ioctl;
>  	net->ethtool_ops = &mcs7830_ethtool_ops;
> -	net->set_multicast_list = mcs7830_set_multicast;
> +	net->netdev_ops = &mcs7830_netdev_ops;
>  	mcs7830_set_multicast(net);
> -	net->set_mac_address = mcs7830_set_mac_address;
>  
>  	/* reserve space for the status byte on rx */
>  	dev->rx_urb_size = ETH_FRAME_LEN + 1;
> 
> -- 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html