netdev - Re: rndis_wlan netdev ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090323.143119.121196854.davem@davemloft.net>
Date:	Mon, 23 Mar 2009 14:31:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org
Subject: Re: rndis_wlan netdev ops

From: Stephen Hemminger <shemminger@...tta.com>
Date: Mon, 23 Mar 2009 14:00:57 -0700

> On Mon, 23 Mar 2009 13:43:18 -0700 (PDT)
> David Miller <davem@...emloft.net> wrote:
> 
> > Probably what we'll have to do for this case is allocate a
> > netdev_ops copy so that the ->set_multicast_list can be set
> > to a new value.  But that defeats the whole purpose of netdev
> > ops so I assume you have other plans :-)
> 
> Why not just turn off the multicast bit in the device, or maybe
> the hardware developer can implement set_multicast_list

We could just import the parent OPS into a local const netdevice_ops
instance, that's how we handle this everywhere else.

To prevent changes in the parent being lost in the rndis driver we can
encapsulate the ops assignments into a macro used by both.  Taking the
set_multicast_list as an arg.

Alternatively the parent can provide a hook function pointer for this
multicast operation, which the parent runs when non-NULL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html