netdev - Re: [PATCH 24/77] usbnet: convert rtl driver to net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0903231117040.4857@bender.nucleusys.com>
Date:	Mon, 23 Mar 2009 11:17:14 +0200 (EET)
From:	Petko Manolov <petkan@...leusys.com>
To:	David Brownell <david-b@...bell.net>
cc:	Stephen Hemminger <shemminger@...tta.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Petko Manolov <petkan@...rs.sourceforge.net>
Subject: Re: [PATCH 24/77] usbnet: convert rtl driver to net_device_ops

ACK :-)


cheers,
Petko



On Sat, 21 Mar 2009, David Brownell wrote:

> On Friday 20 March 2009, Stephen Hemminger wrote:
>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>
> cc'd the maintainer ... by the way, note that
> "usbnet" != "everything in drivers/net/usb" ...
>
>
>> --- a/drivers/net/usb/rtl8150.c	2009-03-20 12:12:47.085715442 -0700
>> +++ b/drivers/net/usb/rtl8150.c	2009-03-20 12:13:41.757841762 -0700
>> @@ -891,6 +891,19 @@ static int rtl8150_ioctl(struct net_devi
>>  	return res;
>>  }
>>
>> +static const struct net_device_ops rtl8150_netdev_ops = {
>> +	.ndo_open		= rtl8150_open,
>> +	.ndo_stop		= rtl8150_close,
>> +	.ndo_do_ioctl		= rtl8150_ioctl,
>> +	.ndo_start_xmit		= rtl8150_start_xmit,
>> +	.ndo_tx_timeout 	= rtl8150_tx_timeout,
>> +	.ndo_set_multicast_list = rtl8150_set_multicast,
>> +	.ndo_set_mac_address	= rtl8150_set_mac_address,
>> +
>> +	.ndo_change_mtu		= eth_change_mtu,
>> +	.ndo_validate_addr	= eth_validate_addr,
>> +};
>> +
>>  static int rtl8150_probe(struct usb_interface *intf,
>>  			 const struct usb_device_id *id)
>>  {
>> @@ -917,15 +930,8 @@ static int rtl8150_probe(struct usb_inte
>>
>>  	dev->udev = udev;
>>  	dev->netdev = netdev;
>> -	netdev->open = rtl8150_open;
>> -	netdev->stop = rtl8150_close;
>> -	netdev->do_ioctl = rtl8150_ioctl;
>> +	netdev->netdev_ops = &rtl8150_netdev_ops;
>>  	netdev->watchdog_timeo = RTL8150_TX_TIMEOUT;
>> -	netdev->tx_timeout = rtl8150_tx_timeout;
>> -	netdev->hard_start_xmit = rtl8150_start_xmit;
>> -	netdev->set_multicast_list = rtl8150_set_multicast;
>> -	netdev->set_mac_address = rtl8150_set_mac_address;
>> -
>>  	SET_ETHTOOL_OPS(netdev, &ops);
>>  	dev->intr_interval = 100;	/* 100ms */
>>
>>
>> --
>>
>>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html