netdev - Re: [PATCH 09/77] irda: convert mcs driver to net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090323113417.GF8199@sortiz.org>
Date:	Mon, 23 Mar 2009 12:34:17 +0100
From:	Samuel Ortiz <samuel@...tiz.org>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 09/77] irda: convert mcs driver to net_device_ops

On Fri, Mar 20, 2009 at 10:35:36PM -0700, Stephen Hemminger wrote:
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
Acked-by: Samuel Ortiz <samuel@...tiz.org>

> 
> ---
>  drivers/net/irda/mcs7780.c |   13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> --- a/drivers/net/irda/mcs7780.c	2009-03-19 22:40:30.408964174 -0700
> +++ b/drivers/net/irda/mcs7780.c	2009-03-19 22:42:47.157714010 -0700
> @@ -873,6 +873,13 @@ static int mcs_hard_xmit(struct sk_buff 
>  	return ret;
>  }
>  
> +static const struct net_device_ops mcs_netdev_ops = {
> +	.ndo_open = mcs_net_open,
> +	.ndo_stop = mcs_net_close,
> +	.ndo_start_xmit = mcs_hard_xmit,
> +	.ndo_do_ioctl = mcs_net_ioctl,
> +};
> +
>  /*
>   * This function is called by the USB subsystem for each new device in the
>   * system.  Need to verify the device and if it is, then start handling it.
> @@ -919,11 +926,7 @@ static int mcs_probe(struct usb_interfac
>  	/* Speed change work initialisation*/
>  	INIT_WORK(&mcs->work, mcs_speed_work);
>  
> -	/* Override the network functions we need to use */
> -	ndev->hard_start_xmit = mcs_hard_xmit;
> -	ndev->open = mcs_net_open;
> -	ndev->stop = mcs_net_close;
> -	ndev->do_ioctl = mcs_net_ioctl;
> +	ndev->netdev_ops = &mcs_netdev_ops;
>  
>  	if (!intf->cur_altsetting)
>  		goto error2;
> 
> -- 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html