netdev - Re: [PATCH] netconsole: fix BUG during net device "upping"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090322.212107.55546529.davem@davemloft.net>
Date:	Sun, 22 Mar 2009 21:21:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mpm@...enic.com
Cc:	marcin.slusarz@...il.com, netdev@...r.kernel.org,
	k-keiichi@...jp.nec.com, stable@...nel.org, rjw@...k.pl,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netconsole: fix BUG during net device "upping"

From: Matt Mackall <mpm@...enic.com>
Date: Sun, 22 Mar 2009 20:20:58 -0500

> On Sun, 2009-03-22 at 12:02 +0100, Marcin Slusarz wrote:
> > When ndo_open (eg skge_up) function printks something, netconsole decides
> > it can use this device because it checks state only (netif_running) which is
> > set before ndo_open. Check device flags too.
> 
> That's fairly unfortunate semantics for netif_running. But if Dave
> agrees that it's reasonable for that to be set to true at this point in
> time, then I guess we'll go with it.

These kind of printk's simply are not allowed, we've removed such
printk's from other driver ->open() methods to fix this problem and
that's what should be done here.

I'm rejecting this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html