[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090323.114928.01832203.davem@davemloft.net>
Date: Mon, 23 Mar 2009 11:49:28 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: Joakim.Tjernlund@...nsmode.se
Cc: leoli@...escale.com, netdev@...r.kernel.org,
linuxppc-dev@...abs.org, avorontsov@...mvista.com
Subject: Re: [PATCH] ucc_geth: Convert to net_device_ops
From: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
Date: Mon, 23 Mar 2009 11:17:39 +0100
> Sorry for the WS damaged patch, but my current company mailer cannot
> handle inline patches. Due to this we are setting up a new mail system
> but it will be a few days before this is ready.
> Therefore I am attaching this patch as well, use that one
> to apply instaed of the inline variant.
This patch has other problems, anyways.
> +#if 0
> +/* not yet */
> + .ndo_set_mac_address = ucc_geth_set_mac_address,
> + .ndo_change_mtu = ucc_geth_change_mtu,
> + .ndo_do_ioctl = ucc_geth_do_ioctl,
> +#endif
Don't do stuff like this, please. Even the code you are
copying from doesn't have the set_mac_address method
assignment proceted by #if 0 stuff.
Just get rid of all the unused stuff completely.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists