netdev - Re: [patch 2.6.29-rc8] dm9000 locking bugfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090322.212857.96030314.davem@davemloft.net>
Date:	Sun, 22 Mar 2009 21:28:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	david-b@...bell.net
Cc:	netdev@...r.kernel.org
Subject: Re: [patch 2.6.29-rc8] dm9000 locking bugfix

From: David Brownell <david-b@...bell.net>
Date: Sun, 22 Mar 2009 16:12:12 -0700

> This fixes a locking bug in the dm9000 driver.  It calls
> request_irq() without setting IRQF_DISABLED ... which is
> correct for handlers that support IRQ sharing, since that
> behavior is not guaranteed for shared IRQs.  However, its
> IRQ handler then wrongly assumes that IRQs are blocked.
> So the fix just uses the right spinlock primitives in the
> IRQ handler.
> 
> NOTE:  this is a classic example of the type of bug which
> lockdep currently masks by forcibly setting IRQF_DISABLED
> on IRQ handlers that did not request that flag.
> 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html