netdev - Re: [PATCH] ucc_geth: Convert to net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF603BDF0B.B740DD77-ONC1257583.007CAD9B-C1257583.007CFD35@transmode.se>
Date:	Tue, 24 Mar 2009 23:45:13 +0100
From:	Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
To:	David Miller <davem@...emloft.net>
Cc:	avorontsov@...mvista.com, leoli@...escale.com,
	linuxppc-dev@...abs.org, netdev@...r.kernel.org
Subject: Re: [PATCH] ucc_geth: Convert to net_device_ops

David Miller <davem@...emloft.net> wrote on 24/03/2009 22:22:09:
> 
> From: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
> Date: Tue, 24 Mar 2009 11:37:11 +0100
> 
> > David Miller <davem@...emloft.net> wrote on 23/03/2009 19:49:28:
> > > 
> > > From: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
> > > Date: Mon, 23 Mar 2009 11:17:39 +0100
> > > 
> > > > Sorry for the WS damaged patch, but my current company mailer 
cannot
> > > > handle inline patches. Due to this we are setting up a new mail 
system
> > > > but it will be a few days before this is ready.
> > > > Therefore I am attaching this patch as well, use that one
> > > > to apply instaed of the inline variant.
> > > 
> > > This patch has other problems, anyways.
> > > 
> > > > +#if 0
> > > > +/* not yet */
> > > > +       .ndo_set_mac_address    = ucc_geth_set_mac_address,
> > > > +       .ndo_change_mtu         = ucc_geth_change_mtu,
> > > > +       .ndo_do_ioctl           = ucc_geth_do_ioctl,
> > > > +#endif
> > > 
> > > Don't do stuff like this, please.  Even the code you are
> > > copying from doesn't have the set_mac_address method
> > > assignment proceted by #if 0 stuff.
> > > 
> > > Just get rid of all the unused stuff completely.
> > 
> > OK, here is a new version. The #if 0 ..#endif has been removed.
> 
> Missing ".ndo_set_mac_address = eth_set_mac_address," and
> also ".ndo_change_mtu = eth_change_mtu".

I don't follow. Are these mandatory now? They were not in the old
impl. either.
> 
> Also please inline your patches so that people can quote them in
> replies.

I know, but my mail system is screwing up WS ATM so I can't. Working
on it though.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html