netdev - Re: [PATCH] r8169: Fix irq masking in rtl8169

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2009 01:38:32 +0100
From:	Karsten Wiese <fzu@...gehoertderstaat.de>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org, Rafael Wysocki <rjw@...k.pl>
Subject: Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt()

Am Montag 23 März 2009 schrieb Francois Romieu:
> Karsten Wiese <fzu@...gehoertderstaat.de> :
> [...]
> > Yes, deavtivated in BIOS.
> 
> Ok, it starts to make some sense.
> 
> Does the patch below make a difference ?

No.

> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 4b7cb38..b5a7358 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -2011,8 +2011,6 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		}
>  	}
>  
> -	pci_set_master(pdev);
> -
>  	/* ioremap MMIO region */
>  	ioaddr = ioremap(pci_resource_start(pdev, region), R8169_REGS_SIZE);
>  	if (!ioaddr) {
> @@ -2039,6 +2037,8 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		msleep_interruptible(1);
>  	}
>  
> +	pci_set_master(pdev);
> +
>  	/* Identify chip attached to board */
>  	rtl8169_get_mac_version(tp, ioaddr);
>  

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html