netdev - Re: [net-next PATCH v3] igbvf: add new driver to support 82576 virtual functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090325150322.40e0a1e6@nehalam>
Date:	Wed, 25 Mar 2009 15:03:22 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, gospo@...hat.com,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: Re: [net-next PATCH v3] igbvf: add new driver to support 82576
 virtual functions

On Wed, 25 Mar 2009 14:52:48 -0700
Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> This adds an igbvf driver to handle virtual functions provided by the
> igb driver when SR-IOV has been enabled.  A virtual function is a
> lightweight pci-e function that supports a single queue and shares
> resources with the 82576 physical function contained within the igb
> driver.
> 
> To spawn virtual functions from the igb driver all that is needed is to
> issue a echo X > /sys/class/ethY/num_vfs.  X can be a value between 0 and
> 7, 0 will disable SR-IOV functionality for the port and is the default.  If
> the num_vfs sysfs entry is not present then the device does not have SR-IOV
> capability enabled either in software or hardware.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Please don't use sysfs for this.
Instead build a proper rtnl_link netlink interface (see macvlan).

Intel doesn't invent unique hardware, other vendors will do the same
thing (or follow your lead), so doing it right the first time for these
kind of devices makes sense.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html