netdev - Re: [net-next PATCH v3] igbvf: add new driver to support 82576 virtual functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090325.165847.234084422.davem@davemloft.net>
Date:	Wed, 25 Mar 2009 16:58:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	alexander.h.duyck@...el.com
Cc:	shemminger@...tta.com, jeffrey.t.kirsher@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com
Subject: Re: [net-next PATCH v3] igbvf: add new driver to support 82576
 virtual functions

From: Alexander Duyck <alexander.h.duyck@...el.com>
Date: Wed, 25 Mar 2009 15:33:31 -0700

> The sysfs part of this is already in net-next as it isn't part of
> the igbvf driver it is part of igb.  It was added in over a month
> ago: http://patchwork.ozlabs.org/patch/23471/
> 
> I will see what we can do to make use of a netlink interface.  I'm
> honestly not even sure if it will work well for this kind of setup
> since the VF driver won't even be running on the same OS in most
> cases.  For now the sysfs code in igb is actually quite minimal, and
> the main goal was to keep the interface as simple as possible which
> is what I have done.

I have to agree with Stephen that the way to create new links
of virtual and similar devices is to use rtnl_link.

We have very good infrastructure for this, and if I understand
things correctly iproute2 might even work with an igb using
rtnl_link with zero modifications to the tool sources.

Please fix this up, it's a very reasonable request for such
a large new piece of driver infrastructure.  And since this is
a new driver, you have no time constraints for submission either.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html