netdev - Re: [RFC] net: release dst entry in dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090324.234354.43714160.davem@davemloft.net>
Date:	Tue, 24 Mar 2009 23:43:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] net: release dst entry in dev_queue_xmit()

From: Eric Dumazet <dada1@...mosbay.com>
Date: Fri, 20 Mar 2009 12:40:22 +0100

> I believe we can release dst in dev_queue_xmit(), while cpu cache is
> hot, since caller of dev_queue_xmit() had to hold a reference on dst
> right before. This reduce work to be done by softirq handler, and
> decrease cache misses.
> 

This will break various packet schedulers and classifiers.

Heck sch_sfq.c even uses skb->dst as part of it's flow hash
function :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html