netdev - Re: [RFC] net: release dst entry in dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090325.001720.238121238.davem@davemloft.net>
Date:	Wed, 25 Mar 2009 00:17:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] net: release dst entry in dev_queue_xmit()

From: Eric Dumazet <dada1@...mosbay.com>
Date: Wed, 25 Mar 2009 08:13:30 +0100

> If done in dev_hard_start_xmit(), skb could be requeued (because of
> NETDEV_TX_BUSY).  Then if requeued, maybe at this time, dst being
> NULL is not a problem ?

Usually it should be OK because the packet schedulers have
a sort-of one-behind state that allows them to reinsert
the SKB into their queue datastructures without reclassifying.

But I'm not %100 sure there isn't some case that might still
need skb->dst there.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html