netdev - Re: [net-next PATCH v3] igbvf: add new driver to support 82576 virtual functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada4oxhufyz.fsf@cisco.com>
Date:	Wed, 25 Mar 2009 20:21:08 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	David Miller <davem@...emloft.net>
Cc:	alexander.h.duyck@...el.com, shemminger@...tta.com,
	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com
Subject: Re: [net-next PATCH v3] igbvf: add new driver to support 82576 virtual functions

 > > Since the issue isn't the igbvf driver there is no reason for it to
 > > be held up.
 > 
 > I disagree, I think both cases should be fixed.
 > 
 > Just because we do something already never means that it's
 > ok to proliferate the mistake further.

The igbvf driver doesn't proliferate any mistake.  The num_vfs sysfs
attribute that everyone finds so objectionable is in the igb driver, and
if you follow the patchwork URL that was provided, you would see that
you applied the patch adding it back in February.  The only thing the
igbvf driver does relating to this is bind to the PCI ID of the virtual
functions created by the igb driver.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html