lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Mar 2009 17:18:13 -0700 (PDT) From: David Miller <davem@...emloft.net> To: thierry.reding@...onic-design.de Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] net: Add support for the OpenCores 10/100 Mbps Ethernet MAC. From: Thierry Reding <thierry.reding@...onic-design.de> Date: Wed, 25 Mar 2009 15:57:07 +0100 > This patch adds a platform device driver that supports the OpenCores 10/100 > Mbps Ethernet MAC. > > The driver expects three resources: one IORESOURCE_MEM resource defines the > memory region for the core's memory-mapped registers while a second > IORESOURCE_MEM resource defines the network packet buffer space. The third > resource, of type IORESOURCE_IRQ, associates an interrupt with the driver. > > Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de> > Acked-by: Florian Fainelli <florian@...nwrt.org> I have some issues with the CONFIG_MII tests. It seems better to just "select MII" in the Kconfig entry for this driver. So could you please do that instead? I don't see how this chip could possible work and obtain a link without the MII interface being setup properly. Besides, the ifdefs are ugly :-) Other than this, the driver looks great. Please fix up this MII issue and I will add the driver to my tree. Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists