netdev - Re: [PATCH] gianfar: fix headroom expansion code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090327.011100.27558565.davem@davemloft.net>
Date:	Fri, 27 Mar 2009 01:11:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	leoli@...escale.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH] gianfar: fix headroom expansion code

From: Li Yang <leoli@...escale.com>
Date: Fri, 27 Mar 2009 16:06:27 +0800

> On Fri, Mar 27, 2009 at 3:39 PM, David Miller <davem@...emloft.net> wrote:
> > From: Li Yang <leoli@...escale.com>
> > Date: Fri, 27 Mar 2009 12:26:33 +0800
> >
> >> We have legacy devices without the offloading feature.  And we can
> >> even turn off the IP checksum offloading at runtime.  Your code will
> >> cause unnecessary realloc for these cases.
> >>
> >> I can propose a new patch to fix the pointer problem and add more
> >> error handling.
> >
> > I'm applying Stephen's patch for now, please send any improvements
> > relative to that.
> 
> Ok.
> 
> However is it ok to use kfree() instead of kfree_skb() in Stephen's patch?
> 
> +               skb_new = skb_realloc_headroom(skb, GMAC_FCB_LEN);
> +               if (!skb_new) {
> +                       dev->stats.tx_errors++;
> +                       kfree(skb);
> +                       return NETDEV_TX_OK;
> +               }

I'll fix this, thanks for noticing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html