netdev - Re: [PATCH] ucc_geth: Fix three oopses in PHY {de,}initialization code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090327.160029.157396274.davem@davemloft.net>
Date:	Fri, 27 Mar 2009 16:00:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	avorontsov@...mvista.com
Cc:	Joakim.Tjernlund@...nsmode.se, leoli@...escale.com,
	netdev@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH] ucc_geth: Fix three oopses in PHY {de,}initialization
 code

From: Anton Vorontsov <avorontsov@...mvista.com>
Date: Fri, 27 Mar 2009 20:40:47 +0300

> When there are no free snums, UCC ethernet should gracefully fail, but
> currently it oopses this way:
 ...
> Also, when device tree specifies fixed-link, and CONFIG_FIXED_PHY
> is disabled, we'll get this oops:
 ...
> This patch fixes all three oopses simply by rearranging some code:
> 
> - In ucc_geth_open(): move init_phy() call to the beginning, so
>   that we only call ucc_geth_stop() with a PHY attached;
> - Move phy_disconnect() call from ucc_geth_close() to
>   ucc_geth_stop(), so that we'll always disconnect the PHY.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>

Applied, thanks Anton.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html