netdev - Re: [PATCH] af_rose/x25: Sanity check the maximum user frame size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090327.002920.134973741.davem@davemloft.net>
Date:	Fri, 27 Mar 2009 00:29:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	alan@...rguk.ukuu.org.uk
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] af_rose/x25: Sanity check the maximum user frame size

From: Alan Cox <alan@...rguk.ukuu.org.uk>
Date: Thu, 26 Mar 2009 21:58:51 +0000

> Otherwise we can wrap the sizes and end up sending garbage.
> 
> Closes #10423
> 
> Signed-off-by: Alan Cox <alan@...rguk.ukuu.org.uk>

Applied, but:

> -	/* Build a packet */
> +	/* Build a packet - the conventional user limit is 236 bytes. We can
> +	   do ludicrously large NetROM frames but must not overflow */
> +	if (len > 65536)
> +		return -EMSGSIZE;
> +	
   ^^^^^^^^^^^^^

please fix the tab monster :-) Or, alternatively, check the patch
either with GIT's automatic checks (or using checkpatch.pl if you
haven't eaten recently)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html