netdev - Re: WARNING: at net/ipv4/tcp_input.c:2927 tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090328045056.GA2394@gentoox2.trippelsdorf.de>
Date:	Sat, 28 Mar 2009 05:50:56 +0100
From:	Markus Trippelsdorf <markus@...ppelsdorf.de>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	Netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: WARNING: at net/ipv4/tcp_input.c:2927 tcp_ack+0xd55/0x1991()

On Sat, Mar 28, 2009 at 01:05:09AM +0200, Ilpo Järvinen wrote:
> On Fri, 27 Mar 2009, Markus Trippelsdorf wrote:
> 
> > I'm running the latest git kernel (2.6.29-03321-gbe0ea69) and I've got
> > this warning twice in the last few hours.:
> 
> What did you run previously?

2.6.29

> 
> > Mar 27 21:37:00 [kernel] ------------[ cut here ]------------
> > Mar 27 21:37:00 [kernel] WARNING: at net/ipv4/tcp_input.c:2927 tcp_ack+0xd55/0x1991()
> 
> This one may or may not be a new one... Starting from the point when the 
> warning was added it has been seen and some of those miscounts got tracked 
> down but there is still something remaining (and that has been the state 
> for couple of version already). It seems to require some particularly hard 
> to reproduce network behavior people usually hit once in a lifetime. 
> However, those miscount alone should not cause crashes, stalled TCP at 
> worst but even that is quite unlikely to happen if fackets_out was not 
> counted right.

The only unusual thing in my setup is that I use two Internet providers
at the same time:

# ip route show
192.168.1.0/24 dev eth1  proto kernel  scope link  src 192.168.1.2
192.168.0.0/24 dev eth0  proto kernel  scope link  src 192.168.0.2
127.0.0.0/8 via 127.0.0.1 dev lo
default equalize
        nexthop via 192.168.1.1  dev eth1 weight 10
        nexthop via 192.168.0.1  dev eth0 weight 1

> 
> > The machine hangs afterwards.
> 
> Is it really related to the warning for sure? I find it hard to 
> believe...

The machine is normally running stable for days. Switching back to 2.6.29
solves the problem...

> 
> We even fixed that miscount for you when the warning was printed out (and 
> the miscount alone wouldn't be able to cause crash anyway). Obviously 
> there could something that got broken but reading through all post 2.6.29 
> tcp material doesn't reveal anything particularly suspicious or even 
> tricky... Only one thing that is remotely related to the warning that gets 
> printed out is d3d2ae454501a4dec360995649e1b002a2ad90c5 but even that has 
> very strong foundation as it does not have any potential to introduce 
> stale references, rest of the effects would be just stalled tcp connection 
> at worst.
> 
> Please add some debugging things, at least lockdep (CONFIG_PROVE_LOCKING) 
> and soft lockup detector (CONFIG_DETECT_SOFTLOCKUP) to find out if we can 
> get some info about the actual place of hang, some other debug things 
> might also end up being useful.

Ok, will try this later today and report back. (It takes ~1 hour to
reproduce the problem with a big torrent download).

-- 
Markus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html