netdev - Re: [PATCH] ni5010: convert to net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090328.193604.230866790.davem@davemloft.net>
Date:	Sat, 28 Mar 2009 19:36:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	a.beregalov@...il.com
Cc:	netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [PATCH] ni5010: convert to net_device_ops

From: Alexander Beregalov <a.beregalov@...il.com>
Date: Sun, 29 Mar 2009 06:26:13 +0400

> @@ -189,6 +189,14 @@ static void __init trigger_irq(int ioaddr)
>  		outb(MM_EN_XMT|MM_MUX, IE_MMODE); /* Start transmission */
>  }
>  
> +static const struct net_device_ops ni5010_netdev_ops = {
> +	.ndo_open		= ni5010_open,
> +	.ndo_stop		= ni5010_close,
> +	.ndo_start_xmit		= ni5010_send_packet,
> +	.ndo_set_multicast_list	= ni5010_set_multicast_list,
> +	.ndo_tx_timeout		= ni5010_timeout,
> +};

Missing:

	.ndo_change_mtu		= eth_change_mtu,
	.ndo_set_mac_address 	= eth_mac_addr,
	.ndo_validate_addr	= eth_validate_addr,

as would have been initialized to dev->foo by alloc_etherdev().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html