netdev - Re: [PATCH 1/3] netfilter: fix endian bug in conntrack printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 28 Mar 2009 23:56:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	harvey.harrison@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] netfilter: fix endian bug in conntrack printks

From: Harvey Harrison <harvey.harrison@...il.com>
Date: Sat, 28 Mar 2009 18:38:30 -0700

> dcc_ip is treated as a host-endian value in the first printk,
> but the second printk uses %pI4 which expects a be32.  This
> will cause a mismatch between the debug statement and the
> warning statement.
> 
> Treat as a be32 throughout and avoid some byteswapping during
> some comparisions, and allow another user of HIPQUAD to bite the
> dust.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>

Applied.

> +			
   ^^^^^^
> +			pr_debug("DCC bound ip/port: %pI4:%u\n",
> +				 &dcc_ip, dcc_port);

Trailing whitespace.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html